[FIX] Refactor views

horilla_views/generic/cbv/views.py

@@ -1607,7 +1607,7 @@ class HorillaCardView(ListView):
 
     filter_class: FilterSet = None
 
-    view_id: str = get_short_uuid(4, prefix="hcv")
+    view_id: str = None
 
     template_name = "generic/horilla_card.html"
     context_object_name = "queryset"
@@ -1651,6 +1651,9 @@ class HorillaCardView(ListView):
         self._saved_filters = QueryDict()
         self.ordered_ids_key = f"ordered_ids_{self.model.__name__.lower()}"
 
+        if not self.view_id:
+            self.view_id = get_short_uuid(4, prefix="hcv")
+
     def get_queryset(self):
         if not self.queryset:
             self.queryset = super().get_queryset()

horilla_views/templates/generic/horilla_kanban_view.html

@@ -28,7 +28,7 @@
         hx-on:click="htmxLoadIndicator(this);"
     ></button>
 
-    {% if show_filter_tags %} {% include "generic/filter_tags.html" %} {% endif %} 
+    {% if show_filter_tags %} {% include "generic/filter_tags.html" %} {% endif %}
 
     <div id="helperContainer" class="hidden" data-model = "{{ app_label }}.{{ model_name }}" data-group-key = "{{view.group_key}}" > </div>
     <div class="flex gap-4 flex-nowrap overflow-auto">
@@ -442,4 +442,3 @@
 
 </script>
 <script src="{% static 'pipeline/pipelineDrag.js' %}"></script>
-

horilla_views/templates/generic/pipeline/kanban_items.html

@@ -8,7 +8,7 @@
 
         <input type="text" name="order" value="{{instance.id}}" hidden>
         <div class="p-[20px] rounded-[5px] text-sm relative bg-white mb-2">
-            <div class="absolute inline-block dropdown-wrapper right-5 top-5 w-3" role="button" 
+            <div class="absolute inline-block dropdown-wrapper right-5 top-5 w-3" role="button"
                 onclick="event.stopPropagation()"
             >
                 <a class="cursor-pointer dropdown-toggle">
@@ -82,7 +82,7 @@
 
         </div>
     </div>
-    
+
     {% if forloop.last and group.page_obj.has_next %}
         <div id ="pagination-container-{{instance.stage_id.id}}" >
             <div
@@ -103,4 +103,4 @@
             </div>
         </div>
     {% endif %}
-{% endfor %}
+{% endfor %}

recruitment/accessibility.py

@@ -14,8 +14,9 @@ def add_candidate_accessibility(
     """
     return (
         request.user.has_perm("recruitment.add_candidate")
-        or request.user.employee_get in instance.stage_managers.all
-        or request.user.employee_get in instance.recruitment_id.recruitment_managers.all
+        or request.user.employee_get in instance.stage_managers.all()
+        or request.user.employee_get
+        in instance.recruitment_id.recruitment_managers.all()
     )
 
 
@@ -28,7 +29,7 @@ def edit_stage_accessibility(
     return (
         request.user.has_perm("recruitment.change_stage")
         or recruitment_manages(request.user, instance.recruitment_id)
-        or request.user.employee_get in instance.stage_managers.all
+        or request.user.employee_get in instance.stage_managers.all()
     )