[UPDT] PMS: Objective progress and key result progress

This commit is contained in:
Horilla
2023-11-28 19:50:41 +05:30
parent 6ea3f5ef1f
commit eddbb5a83a
4 changed files with 59 additions and 24 deletions

View File

@@ -338,9 +338,11 @@ class KeyResultForm(forms.ModelForm):
employee_objective_id = self.initial.get("employee_objective_id")
start_date = cleaned_data.get("start_date")
end_date = cleaned_data.get("end_date")
target_value = cleaned_data.get("target_value")
current_value = cleaned_data.get("current_value")
validate_date(start_date, end_date)
# date comparing with objective start and end date
if employee_objective_id and start_date and end_date:
if start_date < employee_objective_id.start_date:
raise ValidationError("Start date should be after Objective start date")
@@ -349,7 +351,11 @@ class KeyResultForm(forms.ModelForm):
raise ValidationError("End date should be below Objective end date")
else:
raise forms.ValidationError("Employee Objective not found")
# target value and current value comparison
if target_value <= 0:
raise ValidationError("Target value should be greater than zero")
if current_value > target_value:
raise forms.ValidationError("Current value cannot be greater than target value")
return cleaned_data