nestict/ihrm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] HELPDESK: Missing permission in helpdesk delete conditions

Browse Source
This commit is contained in:
Horilla
2024-05-14 16:31:12 +05:30
parent babc994098
commit b972d7139c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
helpdesk/views.py
View File

@@ -1009,7 +1009,7 @@ def comment_edit(request):
@login_required @login_required
def comment_delete(request, comment_id): def comment_delete(request, comment_id):
comment = Comment.objects.filter(id=comment_id) comment = Comment.objects.filter(id=comment_id)
if request.user.has_perm("helpdesk.delete_comment"): if not request.user.has_perm("helpdesk.delete_comment"):
comment = comment.filter(employee_id__employee_user_id=request.user) comment = comment.filter(employee_id__employee_user_id=request.user)
comment.delete() comment.delete()
messages.success( messages.success(
@@ -1214,6 +1214,7 @@ def update_department_manager(request, dep_id):
@login_required @login_required
@permission_required("helpdesk.delete_departmentmanager")
def delete_department_manager(request, dep_id): def delete_department_manager(request, dep_id):
department_manager = DepartmentManager.objects.get(id=dep_id) department_manager = DepartmentManager.objects.get(id=dep_id)
department_manager.delete() department_manager.delete()