From b2787d1099cabdf03c09c25819119ec4bac2f5c3 Mon Sep 17 00:00:00 2001
From: Muhammad Shariq Shafiq <45226@gcslahore.edu.pk>
Date: Wed, 16 Apr 2025 12:05:21 +0500
Subject: [PATCH] Reporting manager can delete but not edit the key results
 (#685)

---
 pms/templates/okr/key_result/kr_card.html | 4 ++++
 pms/templates/okr/key_result/kr_list.html | 4 ++++
 pms/views.py                              | 5 ++---
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/pms/templates/okr/key_result/kr_card.html b/pms/templates/okr/key_result/kr_card.html
index 36308702b..d4c51a536 100644
--- a/pms/templates/okr/key_result/kr_card.html
+++ b/pms/templates/okr/key_result/kr_card.html
@@ -55,6 +55,7 @@
             @click.outside="show = false"
             >
             <ul class="oh-dropdown__items">
+            {% if perms.pms.add_key_result %}
                 <li class="oh-dropdown__item">
                 <a onclick="event.stopPropagation();"
                   data-toggle="oh-modal-toggle"
@@ -63,6 +64,8 @@
                   hx-target="#objectUpdateModalTarget"
                 >{% trans "Edit" %}</a>
                 </li>
+                {% endif %}
+                {% if perms.pms.delete_key_result %}
                 <li class="oh-dropdown__item">
                 <a class="text-danger"
                   onclick = "event.preventDefault();event.stopPropagation();"
@@ -74,6 +77,7 @@
                 >{% trans "Delete" %}</a
                 >
                 </li>
+                {% endif %}
             </ul>
             </div>
         </div>
diff --git a/pms/templates/okr/key_result/kr_list.html b/pms/templates/okr/key_result/kr_list.html
index 53787bfdf..2500daba8 100644
--- a/pms/templates/okr/key_result/kr_list.html
+++ b/pms/templates/okr/key_result/kr_list.html
@@ -104,6 +104,7 @@
                 </div>
                 <div class="oh-sticky-table__td oh-sticky-table__right">
                 <div class="oh-btn-group">
+                    {% if perms.pms.add_key_result %}
                     <a
                     onclick="event.stopPropagation();"
                     class="oh-btn oh-btn--light-bkg w-100"
@@ -121,6 +122,8 @@
                         aria-label="create outline"
                     ></ion-icon>
                     </a>
+                    {% endif %}
+                    {% if perms.pms.delete_key_result %}
                     <a
                     class="oh-btn oh-btn--danger-outline oh-btn--light-bkg w-100"
                     onclick = "event.preventDefault();event.stopPropagation();"
@@ -136,6 +139,7 @@
                         aria-label="trash outline"
                     ></ion-icon>
                     </a>
+                    {% endif %}
                 </div>
                 </div>
             </div>
diff --git a/pms/views.py b/pms/views.py
index 344bdaf15..a46ff4cdf 100644
--- a/pms/views.py
+++ b/pms/views.py
@@ -98,7 +98,7 @@ from pms.models import (
     QuestionOptions,
     QuestionTemplate,
 )
-
+from base.methods import is_reportingmanager
 logger = logging.getLogger(__name__)
 
 
@@ -381,6 +381,7 @@ def kr_create_or_update(request, kr_id=None):
     Returns:
     Renders a form to create or update a Key Result.
     """
+    
     form = KRForm()
     kr = False
     key_result = False
@@ -398,7 +399,6 @@ def kr_create_or_update(request, kr_id=None):
                     % {"key_result": instance},
                 )
                 return HttpResponse("<script>window.location.reload()</script>")
-
         else:
             form = KRForm(request.POST)
             if form.is_valid():
@@ -409,7 +409,6 @@ def kr_create_or_update(request, kr_id=None):
                     % {"key_result": instance},
                 )
                 return HttpResponse("<script>window.location.reload()</script>")
-
     return render(request, "okr/key_result/real_kr_form.html", {"form": form})