From ab332c315a3cde304a5566c3cd0ec5bd5ad5dae8 Mon Sep 17 00:00:00 2001
From: Aarush Dimri <113925979+aarushdimri@users.noreply.github.com>
Date: Thu, 9 Oct 2025 12:02:33 +0530
Subject: [PATCH] Update settings.html (#938)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The “settings.html” template has an else branch that shows Outlook Mail. That link assumes the Outlook integration app/urls are installed. Incase they aren’t, the reverse fails.

Using {% url 'outlook_view_records' as outlook_url %} makes the {% url %} tag not raise if the name doesn’t exist; it just sets an empty string. Then the {% if outlook_url %} hides the link.
---
 templates/settings.html | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/templates/settings.html b/templates/settings.html
index 1968c51e4..082d2c265 100644
--- a/templates/settings.html
+++ b/templates/settings.html
@@ -120,14 +120,17 @@
 												>
 											</div>
 											{% else %}
+											{% url 'outlook_view_records' as outlook_url %} <!-- Added this to gracefully handle exceptions -->
+  											{% if outlook_url %}
 											<div class="oh-input-group">
 													<a
 													id="date"
-													href="{% url 'outlook_view_records' %}"
+													href="{{ outlook_url }}"
 													class="oh-inner-sidebar__link oh-dropdown__link"
 													>{% trans "Outlook Mail" %}</a
 												>
 											</div>
+										{% endif %}
 										{% endif %}
 											<div class="oh-input-group">
 												{% if perms.horilla_backup.view_googledrivebackup %}
@@ -641,3 +644,4 @@
 </script>
 {% endif %}
 {% endblock content %}
+