From a6ce698c6bb0e6c64d1df8a9a8b8eb610a40b9a2 Mon Sep 17 00:00:00 2001
From: Horilla <support@horilla.com>
Date: Wed, 5 Feb 2025 16:51:01 +0530
Subject: [PATCH] [FIX] HORILLA VIEWS: Quick export URI Too long issue

---
 horilla_views/generic/cbv/views.py                     |  4 ++--
 .../templates/generic/export_fields_modal.html         | 10 +++++++---
 horilla_views/templates/generic/quick_actions.html     |  1 -
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/horilla_views/generic/cbv/views.py b/horilla_views/generic/cbv/views.py
index c0b0c3188..ea5e360e8 100644
--- a/horilla_views/generic/cbv/views.py
+++ b/horilla_views/generic/cbv/views.py
@@ -398,8 +398,8 @@ class HorillaListView(ListView):
         from import_export import fields, resources
 
         request = getattr(_thread_locals, "request", None)
-        ids = eval_validate(request.GET["ids"])
-        _columns = eval_validate(request.GET["columns"])
+        ids = eval_validate(request.POST["ids"])
+        _columns = eval_validate(request.POST["columns"])
         queryset = self.model.objects.filter(id__in=ids)
 
         _model = self.model
diff --git a/horilla_views/templates/generic/export_fields_modal.html b/horilla_views/templates/generic/export_fields_modal.html
index 6933d865f..6d07cafd8 100644
--- a/horilla_views/templates/generic/export_fields_modal.html
+++ b/horilla_views/templates/generic/export_fields_modal.html
@@ -18,17 +18,21 @@
       </div>
       <div class="oh-modal__dialog-body">
         <form
+          method="post"
+          action="/{{export_path}}"
           onsubmit="
-            event.preventDefault();
             const selectedFields = $('#{{view_id|safe}} input[name=selected_fields]:checked').map(function() {
                 return [[$(this).attr('data-label'),this.value]];
             }).get();
             selectedIds = $('#{{selected_instances_key_id}}').attr('data-ids');
-            window.location.href = '/{{export_path}}' + '?ids='+selectedIds + '&columns='+JSON.stringify(selectedFields);
-            event.stopPropagation();$(this).parents().find('.oh-modal--show').last().toggleClass('oh-modal--show');
+            $(this).find('[name=ids]').val(selectedIds);
+            $(this).find('[name=columns]').val(JSON.stringify(selectedFields));
           "
           id="candidateExportForm"
         >
+        {% csrf_token %}
+        <input type="hidden" name="ids" id="{{view_id}}ExportIds">
+        <input type="hidden" name="columns" id="{{view_id}}ExportColumns">
 
           <div class="row">
             <div class="col-sm-12 col-md-12 col-lg-6">
diff --git a/horilla_views/templates/generic/quick_actions.html b/horilla_views/templates/generic/quick_actions.html
index 73773592b..8c52201a1 100644
--- a/horilla_views/templates/generic/quick_actions.html
+++ b/horilla_views/templates/generic/quick_actions.html
@@ -79,7 +79,6 @@
         $('#bulk_update_get_form{{view_id}}').click()
         "
         >
-        <ion-icon style="font-size: 1rem; margin-right:0;" name="create"></ion-icon>
         <span class="label"
         {% comment %} style="display: none;" {% endcomment %}
         >