From 7abbe94752018c7dcdb9940e23a97c56ea9feaf4 Mon Sep 17 00:00:00 2001
From: Horilla <support@horilla.com>
Date: Tue, 28 Oct 2025 10:02:09 +0530
Subject: [PATCH] [UPDT] PMS: Employee objective list, view permission is added
 to reporting managers

---
 .../okr/emp_objective/emp_objective_list.html |  2 +-
 pms/templates/okr/kr_list.html                | 66 +++++++++++--------
 2 files changed, 39 insertions(+), 29 deletions(-)

diff --git a/pms/templates/okr/emp_objective/emp_objective_list.html b/pms/templates/okr/emp_objective/emp_objective_list.html
index a812106d4..7fc720f1a 100644
--- a/pms/templates/okr/emp_objective/emp_objective_list.html
+++ b/pms/templates/okr/emp_objective/emp_objective_list.html
@@ -12,7 +12,7 @@
     </div>
 {% endif %}
 {% for emp_objective in emp_objectives.object_list %}
-    {% if perms.pms.view_employeeobjective or emp_objective|is_manager_or_owner:request.user %}
+    {% if perms.pms.view_employeeobjective or emp_objective|is_manager_or_owner:request.user or is_reporting_manager %}
         <div class="oh-accordion-meta">
             <div class="oh-accordion-meta__item">
                 <div class="oh-accordion-meta__header"
diff --git a/pms/templates/okr/kr_list.html b/pms/templates/okr/kr_list.html
index 8cc118fdc..0e3bdf280 100644
--- a/pms/templates/okr/kr_list.html
+++ b/pms/templates/okr/kr_list.html
@@ -70,38 +70,48 @@
                             </span>
                         </div>
                         <div class="oh-sticky-table__td">{{kr.start_value}}</div>
-                        <div class="oh-sticky-table__td">
-                            <input
-                                id = {{kr.id}}
-                                type="number" class="oh-input p-1"  min="0"
-                                max="{{kr.target_value}}"
-                                value="{{kr.current_value}}"
-                                {% comment %} hx-post="{%url 'employee-keyresult-update-current_value' kr.id %}"
-                                hx-trigger="change"
-                                hx-target="#emp_objective_card"  {% endcomment %}
-                                name="current_value"
-                                onchange="delayedProgress(this)"
-                            />
-                        </div>
+                        {% if perms.pms.change_employeeobjective or emp_objective|is_manager:request.user %}
+                            <div class="oh-sticky-table__td">
+                                <input
+                                    id = {{kr.id}}
+                                    type="number" class="oh-input p-1"
+                                    style="width: 100px;"
+                                    min="0"
+                                    value="{{kr.current_value}}"
+                                    name="current_value"
+                                    onchange="delayedProgress(this)"
+                                />
+                            </div>
+
+                        {% else %}
+                            <div class="oh-sticky-table__td">{{kr.current_value}}</div>
+                        {% endif %}
+
                         <div class="oh-sticky-table__td " data-value="{{kr.target_value}}" >{{kr.target_value}}</div>
                         <div class="oh-sticky-table__td p-percentage" >{{kr.progress_percentage}}% </div>
                         <div class="oh-sticky-table__td">{{kr.start_date}}</div>
                         <div class="oh-sticky-table__td">{{kr.end_date}}</div>
-                        <div class="oh-sticky-table__td">
-                            <select
-                                id="keyResultStatus" name="key_result_status"
-                                hx-post="{% url 'employee-keyresult-update-status'  kr.id %}"
-                                hx-trigger="change" class="oh-table__editable-input w-100"
-                                hx-target="#krData{{kr.employee_objective_id.id}}">
-                                    {% for value,label in key_result_status %}
-                                        {% if kr.status != value %}
-                                            <option value="{{value}}">{{label}}</option>
-                                        {% else %}
-                                            <option value="{{value}}" selected>{{label}}</option>
-                                        {% endif%}
-                                    {% endfor %}
-                            </select>
-                        </div>
+                        {% if perms.pms.change_employeeobjective or emp_objective|is_manager:request.user %}
+                            <div class="oh-sticky-table__td">
+                                <select
+                                    id="keyResultStatus" name="key_result_status"
+                                    hx-post="{% url 'employee-keyresult-update-status'  kr.id %}"
+                                    hx-trigger="change" class="oh-table__editable-input w-100"
+                                    hx-target="#krData{{kr.employee_objective_id.id}}">
+                                        {% for value,label in key_result_status %}
+                                            {% if kr.status != value %}
+                                                <option value="{{value}}">{{label}}</option>
+                                            {% else %}
+                                                <option value="{{value}}" selected>{{label}}</option>
+                                            {% endif%}
+                                        {% endfor %}
+                                </select>
+                            </div>
+                        {% else %}
+                            <div class="oh-sticky-table__td">
+                                {{ kr.get_status_display }}
+                            </div>
+                        {% endif %}
                         {% if perms.pms.change_employeeobjective or kr.employee_objective_id|is_manager:request.user %}
                             <div class="oh-sticky-table__td oh-sticky-table__right" onclick="event.stopPropagation()">
                                 <div class="oh-btn-group">