From 659258d942a5404235756ad2e162d07e84de91f8 Mon Sep 17 00:00:00 2001
From: Horilla <teamhorilla@gmail.com>
Date: Mon, 26 Feb 2024 20:14:38 +0530
Subject: [PATCH] [FIX] ONBOARDING: Candidate send portal/trigger onboarding
 issue fix

---
 onboarding/templates/onboarding/candidates_view.html | 6 ++++--
 onboarding/views.py                                  | 9 +++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/onboarding/templates/onboarding/candidates_view.html b/onboarding/templates/onboarding/candidates_view.html
index ab7711d94..45d048dcf 100644
--- a/onboarding/templates/onboarding/candidates_view.html
+++ b/onboarding/templates/onboarding/candidates_view.html
@@ -113,7 +113,9 @@
         <ion-icon name="close-outline"></ion-icon>
       </button>
     </div>
-    <form hx-post="{% url 'email-send' %}" hx-target="#addAttachmentsBody" hx-encoding="multipart/form-data">
+    <form hx-post="{% url 'email-send' %}" 
+    hx-target="#addAttachmentsBody" 
+    hx-encoding="multipart/form-data">
       <div class="oh-modal__dialog-body" id="addAttachmentsBody">
         <section>
           <div id="keyResultsContainer">
@@ -146,7 +148,7 @@
         </section>
       </div>
       <div class="oh-modal__dialog-footer">
-        <button type="button" onclick="$('.oh-modal#addAttachments').removeClass('oh-modal--show');$(`#messages`).html(
+        <button onclick="$('.oh-modal#addAttachments').removeClass('oh-modal--show');$(`#messages`).html(
           $(`
           <div class='oh-alert oh-alert--animated oh-alert--info'>
             Processing...
diff --git a/onboarding/views.py b/onboarding/views.py
index e9888947b..a80c5674f 100644
--- a/onboarding/views.py
+++ b/onboarding/views.py
@@ -29,7 +29,7 @@ from django.views.decorators.http import require_http_methods
 from base.models import JobPosition
 from notifications.signals import notify
 from horilla import settings
-from horilla.decorators import login_required, hx_request_required
+from horilla.decorators import login_required, hx_request_required, logger
 from horilla.decorators import permission_required
 from base.methods import generate_pdf, get_key_instances, get_pagination, sortby
 from onboarding.filters import OnboardingCandidateFilter, OnboardingStageFilter
@@ -668,7 +668,8 @@ def email_send(request):
             email.send()
             # to check ajax or not
             messages.success(request, "Portal link sent to the candidate")
-        except:
+        except Exception as e:
+            logger.error(e)
             messages.error(request, f"Mail not send to {candidate.name}")
         candidate.start_onboard = True
         candidate.save()
@@ -679,8 +680,8 @@ def email_send(request):
             )
             onboarding_candidate.candidate_id = candidate
             onboarding_candidate.save()
-        except:
-            messages.error(request, "Something went wrong.")
+        except Exception as e:
+            logger.error(e)
 
     return HttpResponse("<script>window.location.reload()</script>")