[UPDT] GENERAL: Eval method change (#397)

attendance/views/requests.py

@@ -33,6 +33,7 @@ from attendance.views.clock_in_out import early_out, late_come
 from base.methods import (
     choosesubordinates,
     closest_numbers,
+    eval_validate,
     filtersubordinates,
     get_key_instances,
     is_reportingmanager,
@@ -131,7 +132,7 @@ def request_new(request):
     This method is used to create new attendance requests
     """
 
-    if request.GET.get("bulk") and eval(request.GET.get("bulk")):
+    if request.GET.get("bulk") and eval_validate(request.GET.get("bulk")):
         employee = request.user.employee_get
         form = BulkAttendanceRequestForm(initial={"employee_id": employee})
         if request.method == "POST":
@@ -758,7 +759,7 @@ def get_employee_shift(request):
         employee = Employee.objects.get(id=employee_id)
         shift = employee.get_shift
     form = NewRequestForm()
-    if request.GET.get("bulk") and eval(request.GET.get("bulk")):
+    if request.GET.get("bulk") and eval_validate(request.GET.get("bulk")):
         form = BulkAttendanceRequestForm()
     form.fields["shift_id"].queryset = EmployeeShift.objects.all()
     form.fields["shift_id"].widget.attrs["hx-trigger"] = "load,change"

attendance/views/views.py

@@ -104,6 +104,7 @@ from base.forms import (
 from base.methods import (
     choosesubordinates,
     closest_numbers,
+    eval_validate,
     export_data,
     filtersubordinates,
     get_key_instances,
@@ -1902,7 +1903,7 @@ def create_grace_time(request):
     Returns:
     GET : return grace time form template
     """
-    is_default = eval(request.GET.get("default"))
+    is_default = eval_validate(request.GET.get("default"))
     form = GraceTimeForm(initial={"is_default": is_default})
     if request.method == "POST":
         form = GraceTimeForm(request.POST)
@@ -2694,7 +2695,7 @@ def delete_allowed_ips(request):
         allowed_ips = AttendanceAllowedIP.objects.first()
         ips = allowed_ips.additional_data["allowed_ips"]
         for id in ids:
-            ips.pop(eval(id))
+            ips.pop(eval_validate(id))
 
         allowed_ips.additional_data["allowed_ips"] = ips
         allowed_ips.save()