From cb0e77523da7bcae2affc6aec2a89c52e3454b40 Mon Sep 17 00:00:00 2001
From: Ibnu Maksum <ibnumaksum@gmail.com>
Date: Tue, 6 Aug 2024 10:19:12 +0700
Subject: [PATCH] check if customer username already used by pppoe_username

---
 system/controllers/customers.php | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/system/controllers/customers.php b/system/controllers/customers.php
index b6222faa..baee9405 100644
--- a/system/controllers/customers.php
+++ b/system/controllers/customers.php
@@ -532,20 +532,22 @@ switch ($action) {
         $pppoeDiff = false;
         $passDiff = false;
         if ($oldusername != $username) {
-            $cx = ORM::for_table('tbl_customers')->where('username', $username)->find_one();
-            if ($cx) {
-                $msg .= Lang::T('Account already exist') . '<br>';
+            if (ORM::for_table('tbl_customers')->where('username', $username)->find_one()) {
+                $msg .= Lang::T('Username already used by another customer') . '<br>';
+            }
+            if(ORM::for_table('tbl_customers')->where('pppoe_username', $username)->find_one()){
+                $msg.= Lang::T('Username already used by another customer') . '<br>';
             }
             $userDiff = true;
         }
         if ($oldPppoeUsername != $pppoe_username) {
-            $pppoeDiff = true;
             if(ORM::for_table('tbl_customers')->where('pppoe_username', $pppoe_username)->find_one()){
                 $msg.= Lang::T('PPPoE Username already used by another customer') . '<br>';
             }
             if(ORM::for_table('tbl_customers')->where('username', $pppoe_username)->find_one()){
                 $msg.= Lang::T('PPPoE Username already used by another customer') . '<br>';
             }
+            $pppoeDiff = true;
         }
         if ($password != '' && $oldPassPassword != $password) {
             $passDiff = true;