From 81e30f0c54c5fc4359c23213f33bf8da9e176066 Mon Sep 17 00:00:00 2001
From: Ibnu Maksum <ibnumaksum@gmail.com>
Date: Thu, 22 Aug 2024 10:35:17 +0700
Subject: [PATCH] info if pppoe IP has been used by another customer

---
 system/controllers/customers.php | 18 +++++++++---------
 system/devices/MikrotikPppoe.php |  2 +-
 version.json                     |  2 +-
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/system/controllers/customers.php b/system/controllers/customers.php
index 379db52e..10f9ae1d 100644
--- a/system/controllers/customers.php
+++ b/system/controllers/customers.php
@@ -537,19 +537,19 @@ switch ($action) {
                 $msg .= Lang::T('Username already used by another customer') . '<br>';
             }
             if(ORM::for_table('tbl_customers')->where('pppoe_username', $username)->find_one()){
-                $msg.= Lang::T('Username already used by another customer') . '<br>';
+                $msg.= Lang::T('Username already used by another pppoe username customer') . '<br>';
             }
             $userDiff = true;
         }
         if ($oldPppoeUsername != $pppoe_username) {
-            if(!empty($pppoe_username)){
-                if(ORM::for_table('tbl_customers')->where('pppoe_username', $pppoe_username)->find_one()){
-                    $msg.= Lang::T('PPPoE Username already used by another customer') . '<br>';
-                }
-                if(ORM::for_table('tbl_customers')->where('username', $pppoe_username)->find_one()){
-                    $msg.= Lang::T('PPPoE Username already used by another customer') . '<br>';
-                }
-            }
+            // if(!empty($pppoe_username)){
+            //     if(ORM::for_table('tbl_customers')->where('pppoe_username', $pppoe_username)->find_one()){
+            //         $msg.= Lang::T('PPPoE Username already used by another customer') . '<br>';
+            //     }
+            //     if(ORM::for_table('tbl_customers')->where('username', $pppoe_username)->find_one()){
+            //         $msg.= Lang::T('PPPoE Username already used by another customer') . '<br>';
+            //     }
+            // }
             $pppoeDiff = true;
         }
 
diff --git a/system/devices/MikrotikPppoe.php b/system/devices/MikrotikPppoe.php
index ef7bf796..4cbff181 100644
--- a/system/devices/MikrotikPppoe.php
+++ b/system/devices/MikrotikPppoe.php
@@ -52,7 +52,7 @@ class MikrotikPppoe
             if (!empty($customer['pppoe_ip'])) {
                 $setRequest->setArgument('local-address', $customer['pppoe_ip']);
             }else{
-                $setRequest->setArgument('local-address', '');
+                $setRequest->setArgument('local-address', '0.0.0.0');
             }
             $setRequest->setArgument('profile', $plan['name_plan']);
             $setRequest->setArgument('comment', $customer['fullname'] . ' | ' . $customer['email'] . ' | ' . implode(', ', User::getBillNames($customer['id'])));
diff --git a/version.json b/version.json
index c053e2b5..bbf5eca1 100644
--- a/version.json
+++ b/version.json
@@ -1,3 +1,3 @@
 {
-    "version": "2024.8.21.1"
+    "version": "2024.8.22"
 }
\ No newline at end of file