Use default value instead of value

This commit is contained in:
Joseph Garrone 2021-03-05 00:44:27 +01:00
parent c8e219361b
commit 7daa818996
2 changed files with 15 additions and 17 deletions

View File

@ -44,13 +44,6 @@ export const Login = memo((props: LoginProps) => {
(setIsLoginButtonDisabled(true), true) (setIsLoginButtonDisabled(true), true)
); );
const [ usernameInputValue, setUsernameInputValue ] = useState(login.username ?? '');
const onUsernameChange = useConstCallback(
(event: React.ChangeEvent<HTMLInputElement>)=>
setUsernameInputValue(event.target.value)
);
return ( return (
<Template <Template
displayInfo={social.displayInfo} displayInfo={social.displayInfo}
@ -88,9 +81,8 @@ export const Login = memo((props: LoginProps) => {
id="username" id="username"
className={cx(kcProperties.kcInputClass)} className={cx(kcProperties.kcInputClass)}
name="username" name="username"
value={usernameInputValue} defaultValue={login.username ?? ''}
type="text" type="text"
onChange={onUsernameChange}
{...(usernameEditDisabled ? { "disabled": true } : { "autoFocus": true, "autocomplete": "off" })} {...(usernameEditDisabled ? { "disabled": true } : { "autoFocus": true, "autocomplete": "off" })}
/> />
</div> </div>
@ -109,7 +101,8 @@ export const Login = memo((props: LoginProps) => {
) && ) &&
<div className="checkbox"> <div className="checkbox">
<label> <label>
<input tabIndex={3} id="rememberMe" name="rememberMe" type="checkbox" {...(login.rememberMe ? { "checked": true } : {})}> {t("rememberMe")}</input> <input tabIndex={3} id="rememberMe" name="rememberMe" type="checkbox" {...(login.rememberMe ? { "checked": true } : {})}/>
{t("rememberMe")}
</label> </label>
</div> </div>
} }

View File

@ -53,7 +53,7 @@ export const Register = memo((props: RegisterPageProps) => {
</div> </div>
<div className={cx(kcProperties.kcInputWrapperClass)}> <div className={cx(kcProperties.kcInputWrapperClass)}>
<input type="text" id="firstName" className={cx(kcProperties.kcInputClass)} name="firstName" <input type="text" id="firstName" className={cx(kcProperties.kcInputClass)} name="firstName"
value={register.formData.firstName ?? ""} defaultValue={register.formData.firstName ?? ""}
/> />
</div> </div>
</div> </div>
@ -64,7 +64,7 @@ export const Register = memo((props: RegisterPageProps) => {
</div> </div>
<div className={cx(kcProperties.kcInputWrapperClass)}> <div className={cx(kcProperties.kcInputWrapperClass)}>
<input type="text" id="lastName" className={cx(kcProperties.kcInputClass)} name="lastName" <input type="text" id="lastName" className={cx(kcProperties.kcInputClass)} name="lastName"
value={register.formData.lastName ?? ""} defaultValue={register.formData.lastName ?? ""}
/> />
</div> </div>
</div> </div>
@ -75,7 +75,7 @@ export const Register = memo((props: RegisterPageProps) => {
</div> </div>
<div className={cx(kcProperties.kcInputWrapperClass)}> <div className={cx(kcProperties.kcInputWrapperClass)}>
<input type="text" id="email" className={cx(kcProperties.kcInputClass)} name="email" <input type="text" id="email" className={cx(kcProperties.kcInputClass)} name="email"
value={register.formData.email ?? ""} autoComplete="email" defaultValue={register.formData.email ?? ""} autoComplete="email"
/> />
</div> </div>
</div> </div>
@ -89,7 +89,7 @@ export const Register = memo((props: RegisterPageProps) => {
</div> </div>
<div className={cx(kcProperties.kcInputWrapperClass)}> <div className={cx(kcProperties.kcInputWrapperClass)}>
<input type="text" id="username" className={cx(kcProperties.kcInputClass)} name="username" <input type="text" id="username" className={cx(kcProperties.kcInputClass)} name="username"
value={register.formData.username ?? ""} autoComplete="username" /> defaultValue={register.formData.username ?? ""} autoComplete="username" />
</div> </div>
</div > </div >
@ -139,7 +139,7 @@ export const Register = memo((props: RegisterPageProps) => {
<div id="kc-form-buttons" className={cx(kcProperties.kcFormButtonsClass)}> <div id="kc-form-buttons" className={cx(kcProperties.kcFormButtonsClass)}>
<input className={cx(kcProperties.kcButtonClass, kcProperties.kcButtonPrimaryClass, kcProperties.kcButtonBlockClass, kcProperties.kcButtonLargeClass)} type="submit" <input className={cx(kcProperties.kcButtonClass, kcProperties.kcButtonPrimaryClass, kcProperties.kcButtonBlockClass, kcProperties.kcButtonLargeClass)} type="submit"
value={tStr("doRegister")} /> defaultValue={tStr("doRegister")} />
</div> </div>
</div> </div>
</form > </form >
@ -149,3 +149,8 @@ export const Register = memo((props: RegisterPageProps) => {
}); });
// JSX.IntrinsicElements.input: React.DetailedHTMLProps<React.InputHTMLAttributes<HTMLInputElement>, HTMLInputElement>