From 089f0f7a87830f16c86db1af3b404d27b2c478ec Mon Sep 17 00:00:00 2001
From: garronej <joseph.garrone@data.gouv.fr>
Date: Mon, 17 Apr 2023 01:32:06 +0200
Subject: [PATCH] More explicit naming

---
 src/account/kcContext/createGetKcContext.ts | 8 ++++----
 src/login/kcContext/createGetKcContext.ts   | 8 ++++----
 test/lib/createGetKcContext.spec.ts         | 2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/account/kcContext/createGetKcContext.ts b/src/account/kcContext/createGetKcContext.ts
index 3df844cd..ad8c585e 100644
--- a/src/account/kcContext/createGetKcContext.ts
+++ b/src/account/kcContext/createGetKcContext.ts
@@ -17,13 +17,13 @@ export function createGetKcContext<KcContextExtension extends { pageId: string }
 
     function getKcContext<PageId extends ExtendKcContext<KcContextExtension>["pageId"] | undefined = undefined>(params?: {
         mockPageId?: PageId;
-        storyParams?: DeepPartial<Extract<ExtendKcContext<KcContextExtension>, { pageId: PageId }>>;
+        storyPartialKcContext?: DeepPartial<Extract<ExtendKcContext<KcContextExtension>, { pageId: PageId }>>;
     }): {
         kcContext: PageId extends undefined
             ? ExtendKcContext<KcContextExtension> | undefined
             : Extract<ExtendKcContext<KcContextExtension>, { pageId: PageId }>;
     } {
-        const { mockPageId, storyParams } = params ?? {};
+        const { mockPageId, storyPartialKcContext } = params ?? {};
 
         const realKcContext = getKcContextFromWindow<KcContextExtension>();
 
@@ -52,10 +52,10 @@ export function createGetKcContext<KcContextExtension extends { pageId: string }
                     });
                 }
 
-                if (storyParams !== undefined) {
+                if (storyPartialKcContext !== undefined) {
                     deepAssign({
                         "target": out,
-                        "source": storyParams
+                        "source": storyPartialKcContext
                     });
                 }
 
diff --git a/src/login/kcContext/createGetKcContext.ts b/src/login/kcContext/createGetKcContext.ts
index c26d3f2a..0a8d5d38 100644
--- a/src/login/kcContext/createGetKcContext.ts
+++ b/src/login/kcContext/createGetKcContext.ts
@@ -20,13 +20,13 @@ export function createGetKcContext<KcContextExtension extends { pageId: string }
 
     function getKcContext<PageId extends ExtendKcContext<KcContextExtension>["pageId"] | undefined = undefined>(params?: {
         mockPageId?: PageId;
-        storyParams?: DeepPartial<Extract<ExtendKcContext<KcContextExtension>, { pageId: PageId }>>;
+        storyPartialKcContext?: DeepPartial<Extract<ExtendKcContext<KcContextExtension>, { pageId: PageId }>>;
     }): {
         kcContext: PageId extends undefined
             ? ExtendKcContext<KcContextExtension> | undefined
             : Extract<ExtendKcContext<KcContextExtension>, { pageId: PageId }>;
     } {
-        const { mockPageId, storyParams } = params ?? {};
+        const { mockPageId, storyPartialKcContext } = params ?? {};
 
         const realKcContext = getKcContextFromWindow<KcContextExtension>();
 
@@ -55,10 +55,10 @@ export function createGetKcContext<KcContextExtension extends { pageId: string }
                     });
                 }
 
-                if (storyParams !== undefined) {
+                if (storyPartialKcContext !== undefined) {
                     deepAssign({
                         "target": out,
-                        "source": storyParams
+                        "source": storyPartialKcContext
                     });
                 }
 
diff --git a/test/lib/createGetKcContext.spec.ts b/test/lib/createGetKcContext.spec.ts
index 721dcad4..e25c71d2 100644
--- a/test/lib/createGetKcContext.spec.ts
+++ b/test/lib/createGetKcContext.spec.ts
@@ -235,7 +235,7 @@ describe("createGetKcContext", () => {
 
         const { kcContext } = getKcContext({
             "mockPageId": "login.ftl",
-            "storyParams": {
+            "storyPartialKcContext": {
                 "realm": {
                     displayName
                 }